Bug 102888 – [Chromium] Add tests for datetime/datetime-local suggestion picker

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kunihiko Sakamoto]

Add tests for datetime/datetime-local suggestion picker

[Kunihiko Sakamoto]

Created attachment 175611 [details]
Patch

[Kent Tamura]

Comment on attachment 175611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175611&action=review

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:86
> +shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');

should use shouldBeEqualToString to avoid nested quotes.

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:90
> +    shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');

ditto.

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:93
> +    popupWindow.removeEventListener("resize", test1, false);

quotation mark usage in this test is inconsistent.  Many other part use '

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:98
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:01Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:100
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:02Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:102
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:01Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:106
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:01Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:109
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:02Z"');
> +

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:112
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:40Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:114
> +    shouldBe('highlightedEntry()', '"2012-11-22T02:00Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:116
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:21Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:118
> +    shouldBe('highlightedEntry()', '"2012-11-22T02:00Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:120
> +    shouldBe('highlightedEntry()', '"@openCalendarPicker"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:124
> +    shouldBe('highlightedEntry()', '"@openCalendarPicker"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:128
> +    shouldBe('highlightedEntry()', '"2012-11-22T02:07Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:129
> +    eventSender.keyDown("\n");

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:135
> +    shouldBe('document.getElementById("datetime").value', '"2012-11-22T02:07Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:139
> +    popupWindow.addEventListener("resize", test2, false);

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:143
> +    popupWindow.removeEventListener("resize", test2, false);

ditto.

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:154
> +    shouldBe('document.getElementById("datetime").value', '"2012-11-22T02:07Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html:158
> +        testPassed("F4 opened picker.");

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html:48
> +    shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html:52
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:02Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html:65
> +    shouldBe('document.getElementById("datetime").value', '"2012-11-22T01:03Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html:74
> +    var suggestionList = popupWindow.document.getElementsByClassName("suggestion-list")[0];

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html:102
> +    var suggestionList = popupWindow.document.getElementsByClassName("suggestion-list")[0];

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html:23
> +    shouldBe('highlightedEntry()', '"2012-01-01T00:00Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html:24
> +    eventSender.keyDown("\n");

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html:30
> +    shouldBe('iframe.contentDocument.getElementById("test1").value', '"2012-01-01T00:00Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html:40
> +    shouldBe('highlightedEntry()', '"2012-01-01T00:00Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html:41
> +    eventSender.keyDown("\n");

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html:47
> +    shouldBe('iframe.contentDocument.getElementById("test2").value', '"2012-01-01T00:00Z"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html:49
> +    iframe.addEventListener("load", function () { parent.runOnIFrameLoad(); });

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:86
> +shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:90
> +    shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:98
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:01"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:100
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:02"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:102
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:01"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:106
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:01"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:108
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:02"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:112
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:40"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:114
> +    shouldBe('highlightedEntry()', '"2012-11-22T02:00"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:116
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:21"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:118
> +    shouldBe('highlightedEntry()', '"2012-11-22T02:00"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:120
> +    shouldBe('highlightedEntry()', '"@openCalendarPicker"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:124
> +    shouldBe('highlightedEntry()', '"@openCalendarPicker"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:128
> +    shouldBe('highlightedEntry()', '"2012-11-22T02:07"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:129
> +    eventSender.keyDown("\n");

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:135
> +    shouldBe('document.getElementById("datetime-local").value', '"2012-11-22T02:07"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:139
> +    popupWindow.addEventListener("resize", test2, false);

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html:154
> +    shouldBe('document.getElementById("datetime-local").value', '"2012-11-22T02:07"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html:48
> +    shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html:51
> +    hoverOverElement(popupWindow.document.querySelector(".suggestion-list-entry:nth-child(2)"));

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html:52
> +    shouldBe('highlightedEntry()', '"2012-11-22T01:02"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html:59
> +    clickElement(popupWindow.document.querySelector(".suggestion-list-entry:nth-child(3)"));

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html:65
> +    shouldBe('document.getElementById("datetime-local").value', '"2012-11-22T01:03"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html:102
> +    var suggestionList = popupWindow.document.getElementsByClassName("suggestion-list")[0];

inconsistent quote

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload.html:23
> +    shouldBe('highlightedEntry()', '"2012-01-01T00:00"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload.html:30
> +    shouldBe('iframe.contentDocument.getElementById("test1").value', '"2012-01-01T00:00"');

shouldBeEqualToString

> LayoutTests/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload.html:47
> +    shouldBe('iframe.contentDocument.getElementById("test2").value', '"2012-01-01T00:00"');

shouldBeEqualToString

[Kunihiko Sakamoto]

Created attachment 175627 [details]
Patch 2

[Kunihiko Sakamoto]

Thank you for the review. Addressed all inline comments.

[Kent Tamura]

Comment on attachment 175627 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=175627&action=review

> LayoutTests/ChangeLog:11
> +        * platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png: Added.

This result looks very weird.  Let's discuss it later.

[WebKit Review Bot]

Comment on attachment 175627 [details]
Patch 2

Clearing flags on attachment: 175627

Committed r135676: <http://trac.webkit.org/changeset/135676>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.