HTMLCollection should use the same storage as DynamicNodeList
Created attachment 175348 [details] cleanup
Comment on attachment 175348 [details] cleanup Attachment 175348 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14901855
Created attachment 175502 [details] Fixed GTK+ & FEL builds
Comment on attachment 175502 [details] Fixed GTK+ & FEL builds View in context: https://bugs.webkit.org/attachment.cgi?id=175502&action=review r=me > Source/WebCore/dom/NodeRareData.h:82 > + NodeListAtomicNameCacheMap::AddResult result = m_atomicNameCaches.add( > + namedNodeListKey(DynamicNodeList::PastLastNodeListType + collectionType - FirstNodeCollectionType, starAtom), 0); This spills awkwardly to the next line. You should just construct the key on a separate line. > Source/WebCore/dom/NodeRareData.h:94 > + return static_cast<T*>(m_atomicNameCaches.get(namedNodeListKey(DynamicNodeList::PastLastNodeListType + type - FirstNodeCollectionType, starAtom))); This is pretty long too.
Comment on attachment 175502 [details] Fixed GTK+ & FEL builds Attachment 175502 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14950119
Committed r135429: <http://trac.webkit.org/changeset/135429>
One more build fix for EFL & GTK+ landed in http://trac.webkit.org/changeset/135431.
Curious what (if any) memory/perf effects this is expected to have.
It shouldn't have any.