RESOLVED FIXED 102883
[V8] Remove manually written v8::TryCatch in custom bindings 
https://bugs.webkit.org/show_bug.cgi?id=102883
Summary [V8] Remove manually written v8::TryCatch in custom bindings
Kentaro Hara
Reported 2012-11-20 23:08:46 PST
We can replace them with the EXCEPTION_BLOCK() macro or its friends.
Attachments
Patch (6.89 KB, patch)
2012-11-20 23:17 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (9.25 KB, patch)
2012-11-21 00:14 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-20 23:17:52 PST
Created attachment 175345 [details] Patch
Kentaro Hara
Comment 2 2012-11-20 23:18:37 PST
I'll rename these sadly-named macros in a follow-up patch.
Kentaro Hara
Comment 3 2012-11-21 00:14:16 PST
Created attachment 175354 [details] Patch
Adam Barth
Comment 4 2012-11-21 00:26:56 PST
I'm sure there are tons of bugs in the custom bindings where we forget to look for exceptions when processing arguments.
WebKit Review Bot
Comment 5 2012-11-21 01:39:08 PST
Comment on attachment 175354 [details] Patch Clearing flags on attachment: 175354 Committed r135362: <http://trac.webkit.org/changeset/135362>
WebKit Review Bot
Comment 6 2012-11-21 01:39:12 PST
All reviewed patches have been landed. Closing bug.
John Knottenbelt
Comment 7 2012-11-21 10:00:08 PST
Comment on attachment 175354 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175354&action=review > Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp:83 > if (!type.containsOnlyASCII()) My compiler was complaining that containsType isn't used. Just thought I'd bring it up here, and ask if the code shouldn't read if (containsType && !type.containsOnlyASCII()) ?
Kentaro Hara
Comment 8 2012-11-21 14:09:38 PST
(In reply to comment #7) > My compiler was complaining that containsType isn't used. Just thought I'd bring it up here, and ask if the code shouldn't read > > if (containsType && !type.containsOnlyASCII()) I've already added UNUSED_PARAM(containsType) in a follow-up fix.
Note You need to log in before you can comment on or make changes to this bug.