Bug 102876 - [V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp
Summary: [V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 22:03 PST by Kentaro Hara
Modified: 2012-11-20 22:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.71 KB, patch)
2012-11-20 22:06 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-20 22:03:19 PST 
It doesn't make sense to have one custom cpp file for XXX::constructorCallback() only. We can move XXX::constructorCallback() in v8/custom/V8XXXConstructor.cpp to v8/custom/V8XXXCustom.cpp and thus remove v8/custom/V8XXXConstructor.cpp.

Note: Some XXX::constructorCallback()s are already written in v8/custom/V8XXXCustom.cpp. JSC already has almost all XXX::constructorCallback()s in js/JSXXXCustom.cpp.
Comment 1 Kentaro Hara 2012-11-20 22:06:02 PST 
Created attachment 175338 [details]
Patch
Comment 2 Kentaro Hara 2012-11-20 22:17:11 PST 
Comment on attachment 175338 [details]
Patch

Thanks!
Comment 3 WebKit Review Bot 2012-11-20 22:50:59 PST 
Comment on attachment 175338 [details]
Patch

Clearing flags on attachment: 175338

Committed r135354: <http://trac.webkit.org/changeset/135354>
Comment 4 WebKit Review Bot 2012-11-20 22:51:04 PST 
All reviewed patches have been landed.  Closing bug.