WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
102873
Baseline JIT's disassembly should be just as pretty as the DFG's
https://bugs.webkit.org/show_bug.cgi?id=102873
Summary
Baseline JIT's disassembly should be just as pretty as the DFG's
Filip Pizlo
Reported
2012-11-20 21:57:36 PST
Patch forthcoming.
Attachments
old disassembly
(5.32 KB, text/plain)
2012-11-20 22:05 PST
,
Filip Pizlo
no flags
Details
new disassembly (with my patch)
(6.15 KB, text/plain)
2012-11-20 22:06 PST
,
Filip Pizlo
no flags
Details
the patch
(23.35 KB, patch)
2012-11-20 22:06 PST
,
Filip Pizlo
no flags
Details
Formatted Diff
Diff
the patch
(23.59 KB, patch)
2012-11-20 22:10 PST
,
Filip Pizlo
sam
: review+
Details
Formatted Diff
Diff
patch for landing
(19.88 KB, patch)
2012-11-20 23:51 PST
,
Filip Pizlo
no flags
Details
Formatted Diff
Diff
the patch
(28.14 KB, patch)
2012-11-20 23:54 PST
,
Filip Pizlo
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2012-11-20 22:05:37 PST
Created
attachment 175337
[details]
old disassembly
Filip Pizlo
Comment 2
2012-11-20 22:06:05 PST
Created
attachment 175339
[details]
new disassembly (with my patch)
Filip Pizlo
Comment 3
2012-11-20 22:06:40 PST
Created
attachment 175340
[details]
the patch
Filip Pizlo
Comment 4
2012-11-20 22:10:36 PST
Created
attachment 175341
[details]
the patch For real this time
Filip Pizlo
Comment 5
2012-11-20 22:13:17 PST
Looks like I need to rebase this patch. I will do so after I finish making sure that this is performance-neutral when turned off.
Filip Pizlo
Comment 6
2012-11-20 23:51:10 PST
Created
attachment 175350
[details]
patch for landing
Filip Pizlo
Comment 7
2012-11-20 23:54:06 PST
Created
attachment 175351
[details]
the patch
WebKit Review Bot
Comment 8
2012-11-20 23:58:09 PST
Attachment 175351
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/jit/JITDisassembler.h:62: The parameter name "linkBuffer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/jit/JITDisassembler.h:63: The parameter name "linkBuffer" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 9
2012-11-21 16:48:59 PST
Landed in
http://trac.webkit.org/changeset/135457
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug