ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word because ewk_view_setting_encoding_custom_set triggers the "reload" operation. And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings. The setting word from ewk_view_setting_encoding_custom_XXX APIs should be removed.
Created attachment 175332 [details] Patch
Comment on attachment 175332 [details] Patch This looks like a nice improvement; I suggest a few additional ones: o Please mention in the _set() documentation that the page is going to be reloaded. o "encoding_custom" still sounds a bit weird. How about "ewk_view_custom_encoding_{get,set}" or "ewk_view_custom_text_encoding_{get,set}"?
(In reply to comment #2) > (From update of attachment 175332 [details]) > This looks like a nice improvement; I suggest a few additional ones: > o Please mention in the _set() documentation that the page is going to be reloaded. > o "encoding_custom" still sounds a bit weird. How about "ewk_view_custom_encoding_{get,set}" or "ewk_view_custom_text_encoding_{get,set}"? Thanks for your review. I'll upload new patch.
(In reply to comment #2) > (From update of attachment 175332 [details]) > This looks like a nice improvement; I suggest a few additional ones: > o Please mention in the _set() documentation that the page is going to be reloaded. I checked that it was already mentioned like the below. * Sets the custom character encoding and reloads the page. > o "encoding_custom" still sounds a bit weird. How about "ewk_view_custom_encoding_{get,set}" or "ewk_view_custom_text_encoding_{get,set}"? I'll change that.
Created attachment 175386 [details] Patch
Comment on attachment 175386 [details] Patch LGTM.
Comment on attachment 175386 [details] Patch Clearing flags on attachment: 175386 Committed r135372: <http://trac.webkit.org/changeset/135372>
All reviewed patches have been landed. Closing bug.