Bug 102865 - [EFL][WK2] Correct the parameters of WebPlatformTouchPoint.
Summary: [EFL][WK2] Correct the parameters of WebPlatformTouchPoint.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eunmi Lee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 20:35 PST by Eunmi Lee
Modified: 2012-11-22 00:44 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2012-11-20 20:39 PST, Eunmi Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eunmi Lee 2012-11-20 20:35:20 PST
WebPlatformTouchPoint() gets the screen position as a 3rd parameter and contents position as a fourth parameter,
But we are passing the contents position as a 3rd parameter and screen position as a fourth parameter.
So, I want to correct that.
Comment 1 Eunmi Lee 2012-11-20 20:39:32 PST
Created attachment 175331 [details]
Patch
Comment 2 Laszlo Gombos 2012-11-21 19:16:40 PST
This looks good to me. 

I think it would also help if we could consistently order the arguments everywhere so that screen/device position comes first and content position follows (e.g. in WebEventFactory::createWebTouchEvent(), NativeWebTouchEvent::NativeWebTouchEvent()).

Kenneth, what do you think ?
Comment 3 Kenneth Rohde Christiansen 2012-11-22 00:17:59 PST
Comment on attachment 175331 [details]
Patch

Could this be tested somehow? At least the content position part should be testable
Comment 4 WebKit Review Bot 2012-11-22 00:41:08 PST
Comment on attachment 175331 [details]
Patch

Clearing flags on attachment: 175331

Committed r135491: <http://trac.webkit.org/changeset/135491>
Comment 5 WebKit Review Bot 2012-11-22 00:41:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Eunmi Lee 2012-11-22 00:44:41 PST
(In reply to comment #3)
> (From update of attachment 175331 [details])
> Could this be tested somehow? At least the content position part should be testable

Actually, I found and tested this problem on Tizen.
I agree with you and we need test cases to test positions.