RESOLVED FIXED 102865
[EFL][WK2] Correct the parameters of WebPlatformTouchPoint. 
https://bugs.webkit.org/show_bug.cgi?id=102865
Summary [EFL][WK2] Correct the parameters of WebPlatformTouchPoint.
Eunmi Lee
Reported 2012-11-20 20:35:20 PST
WebPlatformTouchPoint() gets the screen position as a 3rd parameter and contents position as a fourth parameter, But we are passing the contents position as a 3rd parameter and screen position as a fourth parameter. So, I want to correct that.
Attachments
Patch (1.62 KB, patch)
2012-11-20 20:39 PST, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eunmi Lee
Comment 1 2012-11-20 20:39:32 PST
Created attachment 175331 [details] Patch
Laszlo Gombos
Comment 2 2012-11-21 19:16:40 PST
This looks good to me. I think it would also help if we could consistently order the arguments everywhere so that screen/device position comes first and content position follows (e.g. in WebEventFactory::createWebTouchEvent(), NativeWebTouchEvent::NativeWebTouchEvent()). Kenneth, what do you think ?
Kenneth Rohde Christiansen
Comment 3 2012-11-22 00:17:59 PST
Comment on attachment 175331 [details] Patch Could this be tested somehow? At least the content position part should be testable
WebKit Review Bot
Comment 4 2012-11-22 00:41:08 PST
Comment on attachment 175331 [details] Patch Clearing flags on attachment: 175331 Committed r135491: <http://trac.webkit.org/changeset/135491>
WebKit Review Bot
Comment 5 2012-11-22 00:41:13 PST
All reviewed patches have been landed. Closing bug.
Eunmi Lee
Comment 6 2012-11-22 00:44:41 PST
(In reply to comment #3) > (From update of attachment 175331 [details]) > Could this be tested somehow? At least the content position part should be testable Actually, I found and tested this problem on Tizen. I agree with you and we need test cases to test positions.
Note You need to log in before you can comment on or make changes to this bug.