Bug 102850 – Web Inspector: IndexedDB: remove setVersion from inspector tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[David Grogan]

IndexedDB: remove setVersion from inspector tests

[David Grogan]

Created attachment 175300 [details]
Patch

[David Grogan]

Created attachment 175304 [details]
Patch

[David Grogan]

Created attachment 175305 [details]
Patch

[David Grogan]

Josh, could you look at this?

[David Grogan]

Vsevik, could you review this?

[Vsevolod Vlasov]

Comment on attachment 175305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175305&action=review

> LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt:23
> +    version: 

If I understand correctly, the version field should go now? Would you care to remove it from test (and expectations)?
Just remove line 22 in database-structure.html:    InspectorTest.addResult("    version: " + database.version);

> LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js:145
> +        request.onupgradeneeded = function(e) {

We prefer named function style in inspector (and "{" should go to the next line):

request.onupgradeneeded = onUpgradeNeeded;

function onUpgradeNeeded(e)
{
    ...
}

[David Grogan]

Comment on attachment 175305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175305&action=review

Thanks for the review.  Updated patch coming up.

>> LayoutTests/http/tests/inspector/indexeddb/database-structure-expected.txt:23
>> +    version: 
> 
> If I understand correctly, the version field should go now? Would you care to remove it from test (and expectations)?
> Just remove line 22 in database-structure.html:    InspectorTest.addResult("    version: " + database.version);

Done.

>> LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js:145
>> +        request.onupgradeneeded = function(e) {
> 
> We prefer named function style in inspector (and "{" should go to the next line):
> 
> request.onupgradeneeded = onUpgradeNeeded;
> 
> function onUpgradeNeeded(e)
> {
>     ...
> }

Done.

[David Grogan]

Created attachment 175357 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 175357 [details]
Patch for landing

Clearing flags on attachment: 175357

Committed r135365: <http://trac.webkit.org/changeset/135365>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.