Bug 102849 - Simplify builder filters now that we have lists of which builders run which tests
Summary: Simplify builder filters now that we have lists of which builders run which t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 16:15 PST by Ojan Vafai
Modified: 2012-11-20 16:45 PST (History)
5 users (show)

See Also:


Attachments
Patch (27.78 KB, patch)
2012-11-20 16:18 PST, Ojan Vafai
dpranke: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-11-20 16:15:42 PST
Simplify builder filters now that we have lists of which builders run which tests
Comment 1 Ojan Vafai 2012-11-20 16:18:37 PST
Created attachment 175299 [details]
Patch
Comment 2 Dirk Pranke 2012-11-20 16:30:47 PST
Comment on attachment 175299 [details]
Patch

seems fine.
Comment 3 WebKit Review Bot 2012-11-20 16:36:43 PST
Comment on attachment 175299 [details]
Patch

Rejecting attachment 175299 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
zz 3.
patching file Tools/TestResultServer/static-dashboards/builders.js
Hunk #7 FAILED at 235.
Hunk #8 succeeded at 249 (offset -1 lines).
1 out of 8 hunks FAILED -- saving rejects to file Tools/TestResultServer/static-dashboards/builders.js.rej
patching file Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Dirk Pranke']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14905763
Comment 4 Ojan Vafai 2012-11-20 16:45:56 PST
Committed r135334: <http://trac.webkit.org/changeset/135334>