Bug 102847 - Frame::setDocument should not early-attach a Document
Summary: Frame::setDocument should not early-attach a Document
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 15:16 PST by Eric Seidel (no email)
Modified: 2017-07-18 08:29 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2012-11-20 15:19 PST, Eric Seidel (no email)
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-11-20 15:16:06 PST
Frame::setDocument should not early-attach a Document
Comment 1 Eric Seidel (no email) 2012-11-20 15:19:39 PST
Created attachment 175290 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-11-20 15:20:10 PST
I want to make sure that the EWSes are all green before this is landed.  It's possible that this breaks XSLTProcessor tests and will need further refinement.
Comment 3 WebKit Review Bot 2012-11-20 15:56:20 PST
Comment on attachment 175290 [details]
Patch

Attachment 175290 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14934404

New failing tests:
css2.1/20110323/absolute-replaced-height-007.htm
compositing/framesets/composited-frame-alignment.html
css2.1/20110323/float-replaced-height-007.htm
css2.1/20110323/float-replaced-height-005.htm
css2.1/20110323/absolute-replaced-height-014.htm
css2.1/20110323/block-replaced-height-005.htm
css2.1/20110323/block-replaced-height-007.htm
css2.1/20110323/absolute-replaced-height-005.htm
css2.1/20110323/absolute-replaced-height-011.htm
css2.1/20110323/inline-block-replaced-height-005.htm
compositing/geometry/fixed-position-iframe-composited-page-scale.html
css2.1/20110323/absolute-replaced-height-035.htm
css2.1/20110323/absolute-replaced-height-032.htm
http/tests/css/shared-stylesheet-mutation-preconstruct.html
css2.1/20110323/absolute-replaced-height-018.htm
http/tests/inspector/network/network-image-404.html
css2.1/20110323/absolute-replaced-height-028.htm
css2.1/20110323/float-replaced-height-004.htm
http/tests/inspector/web-socket-frame-error.html
css2.1/20110323/absolute-replaced-height-033.htm
css2.1/20110323/absolute-replaced-height-012.htm
http/tests/css/shared-stylesheet-mutation.html
css2.1/20110323/absolute-replaced-height-025.htm
compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
css2.1/20110323/absolute-replaced-height-004.htm
css2.1/20110323/inline-block-replaced-height-004.htm
css2.1/20110323/absolute-replaced-height-019.htm
css2.1/20110323/absolute-replaced-height-026.htm
css2.1/20110323/absolute-replaced-height-021.htm
css2.1/20110323/block-replaced-height-004.htm
Comment 4 Eric Seidel (no email) 2012-11-20 15:57:23 PST
Comment on attachment 175290 [details]
Patch

Oh noes!  Will investigate.
Comment 5 Build Bot 2012-11-20 19:58:54 PST
Comment on attachment 175290 [details]
Patch

Attachment 175290 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14905821

New failing tests:
accessibility/iframe-bastardization.html
css2.1/20110323/absolute-replaced-height-007.htm
compositing/framesets/composited-frame-alignment.html
css2.1/20110323/float-replaced-height-007.htm
css2.1/20110323/float-replaced-height-005.htm
css2.1/20110323/inline-block-replaced-height-007.htm
css2.1/20110323/block-replaced-height-005.htm
css2.1/20110323/inline-replaced-height-004.htm
css2.1/20110323/block-replaced-height-007.htm
css2.1/20110323/absolute-replaced-height-005.htm
css2.1/20110323/absolute-replaced-height-011.htm
css2.1/20110323/inline-block-replaced-height-005.htm
css2.1/20110323/absolute-replaced-height-035.htm
css2.1/20110323/inline-replaced-height-005.htm
accessibility/loading-iframe-updates-axtree.html
css2.1/20110323/absolute-replaced-height-032.htm
css2.1/20110323/inline-replaced-height-007.htm
css2.1/20110323/absolute-replaced-height-014.htm
css2.1/20110323/absolute-replaced-height-018.htm
css2.1/20110323/absolute-replaced-height-028.htm
css2.1/20110323/float-replaced-height-004.htm
css2.1/20110323/absolute-replaced-height-033.htm
css2.1/20110323/absolute-replaced-height-012.htm
css2.1/20110323/absolute-replaced-height-025.htm
css2.1/20110323/absolute-replaced-height-004.htm
css2.1/20110323/inline-block-replaced-height-004.htm
css2.1/20110323/absolute-replaced-height-019.htm
css2.1/20110323/absolute-replaced-height-026.htm
css2.1/20110323/absolute-replaced-height-021.htm
css2.1/20110323/block-replaced-height-004.htm
Comment 6 Eric Seidel (no email) 2012-11-22 00:15:24 PST
BTW, although I believe this is a good patch (and could be cleaned up to work properly).  It's not as important as I had originally thought, so I don't plan to come back to it immediately.