Bug 102843 – HTMLCollection's cache should not be invalidated when id or name attributes are changed

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryosuke Niwa]

HTMLCollection's cache should not be invalidated when id or name attributes are changed

[Ryosuke Niwa]

Created attachment 175286 [details]
Fixes the bug

[Eric Seidel (no email)]

Comment on attachment 175286 [details]
Fixes the bug

YES.  This is easy to test though.  Just iterate over table.rows and set a name on each.  It will be O(N^2) w/o this fix.  Ojan's order-of-magnitude framework makes this trivial.

[Ryosuke Niwa]

(In reply to comment #2)
> (From update of attachment 175286 [details])
> YES.  This is easy to test though.  Just iterate over table.rows and set a name on each.  It will be O(N^2) w/o this fix.  Ojan's order-of-magnitude framework makes this trivial.

I've tried that but my test was consistently flaky.

[Eric Seidel (no email)]

I didn't have that trouble with his framework, but I guess YMMV?  Sadly the tests I wrote in this style are on a different machine I may not have access to for a week.

[Rafael Brandao]

Comment on attachment 175286 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=175286&action=review

> Source/WebCore/dom/DynamicNodeList.h:83
> +    void invalididateIdNameCacheMaps() const;

Typo on "invalididate", should be "invalidate", right?

[Ryosuke Niwa]

Committed r135321: <http://trac.webkit.org/changeset/135321>

[Ryosuke Niwa]

Fixed typos in http://trac.webkit.org/changeset/135323 and http://trac.webkit.org/changeset/135327.