Bug 102840 - Remove unused ScrollByPixelVelocity
Summary: Remove unused ScrollByPixelVelocity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Kroeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 14:54 PST by Robert Kroeger
Modified: 2012-11-23 16:43 PST (History)
7 users (show)

See Also:

Attachments
Patch (12.61 KB, patch)
2012-11-21 11:41 PST, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Patch (14.00 KB, patch)
2012-11-21 12:30 PST, Robert Kroeger 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Kroeger 2012-11-20 14:54:12 PST 
Per https://bugs.webkit.org/show_bug.cgi?id=80311 I added support for fling via ScrollAnimatorNone using the ScrollByPixelVelocity scroll subtype. This code was ill-considered and (as best as I can tell) not used by any platform as it doesn't actually work properly. Remove it.
Comment 1 Robert Kroeger 2012-11-21 11:41:36 PST 
Created attachment 175491 [details]
Patch
Comment 2 Robert Kroeger 2012-11-21 12:30:05 PST 
Created attachment 175499 [details]
Patch
Comment 3 Robert Kroeger 2012-11-21 12:35:57 PST 
Allan: I believe that ScrollByPixelVelocityWheelEvent-type wheel events with non-zero velocities are never actually dispatched on any platform. I.E.: GestureScrollEnd never initiates a fling. It doesn't on Chromium or Mac platforms. Could you have a look at this patch and comment?
Comment 4 Allan Sandfeld Jensen 2012-11-23 07:23:36 PST 
(In reply to comment #3)
> Allan: I believe that ScrollByPixelVelocityWheelEvent-type wheel events with non-zero velocities are never actually dispatched on any platform. I.E.: GestureScrollEnd never initiates a fling. It doesn't on Chromium or Mac platforms. Could you have a look at this patch and comment?

Qt never uses GestureScrollEnd with velocity either. This is either provided by hardware (mouse wheel, touchpad) or the application environment (touch screen).
Comment 5 WebKit Review Bot 2012-11-23 16:43:24 PST 
Comment on attachment 175499 [details]
Patch

Clearing flags on attachment: 175499

Committed r135638: <http://trac.webkit.org/changeset/135638>
Comment 6 WebKit Review Bot 2012-11-23 16:43:27 PST 
All reviewed patches have been landed.  Closing bug.