Bug 102818 - Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHttpRequest, Prerenderer, HTMLMediaElement
Summary: Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 09:09 PST by Ilya Tikhonovsky
Modified: 2012-11-21 04:27 PST (History)
13 users (show)

See Also:

Attachments
Patch (7.67 KB, patch)
2012-11-20 09:13 PST, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (10.80 KB, patch)
2012-11-21 01:45 PST, Ilya Tikhonovsky 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-11-20 09:09:46 PST 
Our test bot counts pointers which don't match with objects allocated by tcmalloc.
This counter becomes nonzero after instrumenting ActiveDOMObject class.
It happens because it is the base class for many other classes. ~30
And almost all these classes use multiple inheritance.
Comment 1 Ilya Tikhonovsky 2012-11-20 09:13:10 PST 
Created attachment 175230 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-11-21 01:45:10 PST 
Created attachment 175378 [details]
Patch
Comment 3 Ilya Tikhonovsky 2012-11-21 04:27:44 PST 
Committed r135384: <http://trac.webkit.org/changeset/135384>