Bug 102813 – Web Inspector: DataGrid: avoid repetitive access to node data field.

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

DataGridNode.data is a getter.
Each access to "data" causes construction of object that
contains presentation values for all fields.

There are few loops in which this field is accessed repetitively.
With this patch in most loops "data" result reused.

Created attachment 175213 [details]
Patch

Created attachment 175214 [details]
Patch

[Pavel Feldman]

Comment on attachment 175214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175214&action=review

> Source/WebCore/ChangeLog:9
> +        Each access to "data" causes construction of object that

Could you explain what object is constructed? I can only see

    get data()
    {
        return this._data;
    },

in WebInspector.DataGridNode.prototype. This does not cost anything.

Comment on attachment 175214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175214&action=review

>> Source/WebCore/ChangeLog:9
>> +        Each access to "data" causes construction of object that
> 
> Could you explain what object is constructed? I can only see
> 
>     get data()
>     {
>         return this._data;
>     },
> 
> in WebInspector.DataGridNode.prototype. This does not cost anything.

Most classes that extend DataGridNode override this getter with one that construct object.

[Brian Burg]

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.