Bug 102812 - Remove '#include "ScriptCallStackFactory.h"' include when unnecessary.
Summary: Remove '#include "ScriptCallStackFactory.h"' include when unnecessary.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 06:53 PST by Mike West
Modified: 2012-11-20 09:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.77 KB, patch)
2012-11-20 06:57 PST, Mike West 		no flags Details | Formatted Diff | Diff
Patch for landing (3.86 KB, patch)
2012-11-20 09:42 PST, Mike West 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2012-11-20 06:53:21 PST 
"ScriptCallStackFactory.h" is included in a few files where it doesn't seem to be required. Since I'm in the process of centralizing stack trace generation anyway, I'll just clean this up as a drive-by.
Comment 1 Mike West 2012-11-20 06:57:33 PST 
Created attachment 175208 [details]
Patch
Comment 2 Mike West 2012-11-20 06:58:53 PST 
Hey Jochen, assuming this compiles, WDYT?
Comment 3 jochen 2012-11-20 07:01:19 PST 
Comment on attachment 175208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175208&action=review

> Source/WebCore/ChangeLog:3
> +        Remove '#include "ScriptCallStackFactory.h"' include when unnecessary.

you also remove one occurrence of ScriptCallStack.h, can you somehow note this in the ChangeLog
Comment 4 Mike West 2012-11-20 09:42:11 PST 
Created attachment 175234 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-11-20 09:59:27 PST 
Comment on attachment 175234 [details]
Patch for landing

Clearing flags on attachment: 175234

Committed r135291: <http://trac.webkit.org/changeset/135291>
Comment 6 WebKit Review Bot 2012-11-20 09:59:31 PST 
All reviewed patches have been landed.  Closing bug.