Bug 102810 - [Qt] No test of double-click to zoom out
Summary: [Qt] No test of double-click to zoom out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 06:41 PST by Allan Sandfeld Jensen
Modified: 2012-11-20 08:11 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.88 KB, patch)
2012-11-20 06:45 PST, Allan Sandfeld Jensen
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-11-20 06:41:21 PST
We have a basic test of double-click to zoom, but it doesn't test any of the finer behavior of double click to zoom out. Since this behaviour is more complicated, it is probably more likely to be broken by accidently and should therefore have be tested.
Comment 1 Allan Sandfeld Jensen 2012-11-20 06:45:31 PST
Created attachment 175203 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-11-20 07:57:18 PST
Comment on attachment 175203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175203&action=review

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:101
> +        }
> +        function test_double_zoomInAndBack() {

newline?
Comment 3 Allan Sandfeld Jensen 2012-11-20 08:11:11 PST
Committed r135282: <http://trac.webkit.org/changeset/135282>