This is an incremental step for V8Parameter refactoring. V8Parameter::prepare() is always called just after V8Parameter's constructor. So I want to move the logic of V8Parameter::prepare() to V8Parameter's constructor. In preparation for that, this patch changes the return type of V8Parameter::prepare() from bool to void (because a constructor cannot return any value).
Created attachment 175196 [details] Patch
Comment on attachment 175196 [details] Patch Attachment 175196 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14911682 New failing tests: fast/workers/worker-constructor.html storage/websql/sql-error-codes.html inspector/console/alert-toString-exception.html http/tests/websocket/tests/hybi/send-throw.html fast/workers/storage/execute-sql-args-sync.html fast/workers/storage/open-database-inputs-sync.html fast/workers/storage/execute-sql-args-worker.html fast/workers/storage/sql-exception-codes-sync.html storage/websql/execute-sql-args.html
Comment on attachment 175196 [details] Patch Looks like you have some test failures to work through.
Created attachment 175309 [details] Fixed test failures
Comment on attachment 175309 [details] Fixed test failures Clearing flags on attachment: 175309 Committed r135338: <http://trac.webkit.org/changeset/135338>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 102981
bug 102981 which reopened this automatically has been resolved. I think it's ok to close this bug.