Bug 102803 - [Qt] Zoom logic confused by page and pinch resize
Summary: [Qt] Zoom logic confused by page and pinch resize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 05:00 PST by Allan Sandfeld Jensen
Modified: 2012-11-20 05:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.68 KB, patch)
2012-11-20 05:04 PST, Allan Sandfeld Jensen 		kenneth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-11-20 05:00:08 PST 
The zoom logic can act in very surprising ways after a page resize or a pinch zoom. The problem is for page resize that the zoom-out stack is not cleared, and for both pinch zoom and page resize that all later zooms are treated as ZoomIn even if they are zooming out, or trying to zoom back to the unzoomed page.
Comment 1 Allan Sandfeld Jensen 2012-11-20 05:04:06 PST 
Created attachment 175194 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-11-20 05:09:01 PST 
Can this be tested with a qml unit test?
Comment 3 Allan Sandfeld Jensen 2012-11-20 05:16:17 PST 
(In reply to comment #2)
> Can this be tested with a qml unit test?

Possibly, currently we have only very limited tests of double-tap to zoom. So I would start by adding tests of zoom-back, zoom-out and a lot of other behavior before this comes up.
Comment 4 Allan Sandfeld Jensen 2012-11-20 05:19:43 PST 
Committed r135272: <http://trac.webkit.org/changeset/135272>