RESOLVED FIXED 102792
Web Inspector: Script Profiler: Make profiler output typed.
https://bugs.webkit.org/show_bug.cgi?id=102792
Summary Web Inspector: Script Profiler: Make profiler output typed.
eustas.bug
Reported 2012-11-20 04:06:20 PST
Currently fields "head" and "bottomUpHead" of Profile object returned by Profiler.getProfile is untyped (type = object). That's not good both for client side (protocol users may only guess on output content) and backend side (field names are hardcoded in source code). This patch defines "head" and "bottomUpHead" to be of new "ProfileNode" type and updates serialization code to use builders to create output.
Attachments
Patch (10.84 KB, patch)
2012-11-20 04:10 PST, eustas.bug
no flags
Patch (11.50 KB, patch)
2013-01-29 05:38 PST, Eugene Klyuchnikov
no flags
Patch (10.99 KB, patch)
2013-01-29 05:43 PST, Eugene Klyuchnikov
no flags
eustas.bug
Comment 1 2012-11-20 04:10:33 PST
Yury Semikhatsky
Comment 2 2012-11-20 23:56:28 PST
Comment on attachment 175186 [details] Patch We should first split Heap snapshots and CPU profiles. Currently they are all described by Profiler.Profile object in the protocol which seems wrong and makes front-end implementation too complicated.
Eugene Klyuchnikov
Comment 3 2013-01-29 05:38:56 PST
Eugene Klyuchnikov
Comment 4 2013-01-29 05:43:47 PST
kov's GTK+ EWS bot
Comment 5 2013-01-29 08:27:57 PST
Yury Semikhatsky
Comment 6 2013-01-30 07:35:16 PST
Comment on attachment 185225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=185225&action=review > Source/WebCore/bindings/v8/ScriptProfile.h:38 > +#if ENABLE(INSPECTOR) Can we hide the whole file behind the guard?
Eugene Klyuchnikov
Comment 7 2013-01-30 07:46:44 PST
(In reply to comment #6) > (From update of attachment 185225 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185225&action=review > > > Source/WebCore/bindings/v8/ScriptProfile.h:38 > > +#if ENABLE(INSPECTOR) > > Can we hide the whole file behind the guard? Not sure. Collecting profile is a console feature.
WebKit Review Bot
Comment 8 2013-01-30 08:17:09 PST
Comment on attachment 185225 [details] Patch Clearing flags on attachment: 185225 Committed r141273: <http://trac.webkit.org/changeset/141273>
WebKit Review Bot
Comment 9 2013-01-30 08:17:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.