Bug 102774 - [V8] Remove V8ParameterBase
Summary: [V8] Remove V8ParameterBase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 23:52 PST by Kentaro Hara
Modified: 2012-11-20 01:56 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2012-11-19 23:54 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (3.93 KB, patch)
2012-11-20 01:34 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-19 23:52:04 PST 
V8ParameterBase is redundant.
Comment 1 Kentaro Hara 2012-11-19 23:54:02 PST 
Created attachment 175159 [details]
Patch
Comment 2 Kentaro Hara 2012-11-19 23:55:45 PST 
After landing this patch, I'll merge prepare() with V8Parameter's constructor (prepare() is always called just after constructing V8Parameter). I'll also rename V8Parameter to a better name (V8Parameter is just a "super" class for String and AtomicString).
Comment 3 Adam Barth 2012-11-20 01:24:21 PST 
Comment on attachment 175159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175159&action=review

> Source/WebCore/bindings/v8/V8StringResource.h:52
> +template <V8ParameterMode MODE = DefaultMode>

MODE -> Mode

> Source/WebCore/bindings/v8/V8StringResource.h:55
> +    V8Parameter(v8::Local<v8::Value> object) : m_v8Object(object), m_mode(Externalize), m_string() { }

Please split this up into multiple lines.
Comment 4 Kentaro Hara 2012-11-20 01:34:13 PST 
Created attachment 175172 [details]
patch for landing
Comment 5 WebKit Review Bot 2012-11-20 01:56:43 PST 
Comment on attachment 175172 [details]
patch for landing

Clearing flags on attachment: 175172

Committed r135266: <http://trac.webkit.org/changeset/135266>
Comment 6 WebKit Review Bot 2012-11-20 01:56:47 PST 
All reviewed patches have been landed.  Closing bug.