Bug 102773 - [EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp
Summary: [EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClie...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 23:29 PST by Jaehun Lim
Modified: 2012-11-21 16:21 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2012-11-19 23:31 PST, Jaehun Lim 		no flags Details | Formatted Diff | Diff
Patch (1.33 KB, patch)
2012-11-21 14:45 PST, Jaehun Lim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2012-11-19 23:29:23 PST 
PageViewportControllerClientEfl.cpp doesn't need to include ewk_view_private.h.
Comment 1 Jaehun Lim 2012-11-19 23:31:35 PST 
Created attachment 175154 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-11-20 02:01:00 PST 
Comment on attachment 175154 [details]
Patch

Looks OK.
Comment 3 Laszlo Gombos 2012-11-21 13:50:09 PST 
Comment on attachment 175154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175154&action=review

Overall looks good.

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2] Remove #include #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp

Please remove the double #include.
Comment 4 Jaehun Lim 2012-11-21 14:45:39 PST 
Created attachment 175525 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-21 16:21:23 PST 
Comment on attachment 175525 [details]
Patch

Clearing flags on attachment: 175525

Committed r135453: <http://trac.webkit.org/changeset/135453>
Comment 6 WebKit Review Bot 2012-11-21 16:21:27 PST 
All reviewed patches have been landed.  Closing bug.