WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
102768
Merge checks for creating renderers into shouldCreateRenderer
https://bugs.webkit.org/show_bug.cgi?id=102768
Summary
Merge checks for creating renderers into shouldCreateRenderer
Elliott Sprehn
Reported
2012-11-19 22:13:33 PST
Merge checks for creating renderers into shouldCreateRenderer
Attachments
Patch
(2.48 KB, patch)
2012-11-19 22:21 PST
,
Elliott Sprehn
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Elliott Sprehn
Comment 1
2012-11-19 22:21:57 PST
Created
attachment 175141
[details]
Patch
Elliott Sprehn
Comment 2
2012-11-19 22:28:23 PST
I can't find anyone who ever actually sets the document level shouldCreateRenderers to false, so this would seem to be dead code, though it is exposed for the mac port in the WebFramePrivate.h header so maybe Safari uses it internally? I suppose the feature is theoretically useful for future ports/features too...
WebKit Review Bot
Comment 3
2012-11-20 09:45:11 PST
Comment on
attachment 175141
[details]
Patch Clearing flags on attachment: 175141 Committed
r135290
: <
http://trac.webkit.org/changeset/135290
>
WebKit Review Bot
Comment 4
2012-11-20 09:45:14 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug