Bug 102758 – [Blackberry] When a frame is being detached, cancel all its network jobs.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Chris.Guan]

When a frame is being detached, cancel all its network jobs with exception of
PingLoader.

This is a follow-up of RIM PR134207.

Each NetworkJob contains a pointer to Frame. The safety relies on the
assumption that FrameLoader::stopAllLoaders() always cancels all network jobs
that belongs to the frame (except PingLoader, for which we unlink the
NetworkJob from the Frame, so it is safe). If one day that is no longer true,
we are in trouble.

We already maintain the full list of active NetworkJob in the NetworkManager
skeleton. So it is easy to cancel all network jobs that link to the
falling-down Frame if any, or clear their m_frame pointers... At least we
should assert no such NetworkJob exists in debug build.

[Chris.Guan]

Created attachment 175120 [details]
Patch

[WebKit Review Bot]

Attachment 175120 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:16:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[George Staikos]

Comment on attachment 175120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175120&action=review

I like this patch a lot.  I don't think it's worth it to fix the typo in the commit log as a new round of changes.

> Source/WebCore/ChangeLog:8
> +        I use FrameDestructionObserver to refatcor Networkjob code.

Typo here - refactor

[George Staikos]

(In reply to comment #2)
> Attachment 175120 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> Source/WebCore/ChangeLog:15:  Line contains tab character.  [whitespace/tab] [5]
> Source/WebCore/ChangeLog:16:  Line contains tab character.  [whitespace/tab] [5]
> Total errors found: 2 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

But you have to fix these.  So you might as well fix the typo too

[Chris.Guan]

Created attachment 175123 [details]
Patch

[Chris.Guan]

Created attachment 175124 [details]
Patch

[WebKit Review Bot]

Comment on attachment 175124 [details]
Patch

Clearing flags on attachment: 175124

Committed r135243: <http://trac.webkit.org/changeset/135243>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.