Bug 102756 - [Refacotring] Remove WebCore::isInsertionPoint(Node*)
Summary: [Refacotring] Remove WebCore::isInsertionPoint(Node*)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 18:24 PST by Shinya Kawanaka
Modified: 2012-11-19 22:10 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.40 KB, patch)
2012-11-19 18:27 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch for landing (6.41 KB, patch)
2012-11-19 21:52 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-11-19 18:24:33 PST 
This is a follow-up for Bug 100738.
Now that WebCore::isInsertionPoint(Node*) does nothing. We can remove this.
Comment 1 Shinya Kawanaka 2012-11-19 18:27:52 PST 
Created attachment 175106 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-19 21:15:34 PST 
Comment on attachment 175106 [details]
Patch

Attachment 175106 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14899452

New failing tests:
fast/dom/shadow/content-reprojection-fallback-reprojection.html
fast/dom/shadow/content-child-whitespace-between-span.html
fast/dom/shadow/composed-shadow-tree-walker.html
fast/dom/shadow/content-element-distributed-nodes.html
fast/dom/shadow/focus-navigation-with-distributed-nodes.html
fast/dom/shadow/focus-navigation.html
fast/dom/shadow/content-reprojection-complex.html
fast/dom/shadow/events-stopped-at-shadow-boundary.html
fast/dom/shadow/content-element-select-dynamic.html
fast/dom/shadow/athost-atrules.html
fast/dom/shadow/distribution-className-modified.html
fast/dom/shadow/content-element-move.html
fast/dom/shadow/content-reprojection-dynamic.html
fast/dom/shadow/content-reprojection-fallback.html
fast/dom/shadow/content-reprojection-shadow.html
fast/dom/shadow/create-content-element.html
fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection.html
fast/dom/shadow/content-element-outside-shadow-style.html
fast/dom/shadow/distribution-id-modified.html
fast/dom/shadow/content-reprojection-fallback-crash.html
editing/shadow/delete-list-in-shadow.html
fast/block/block-remove-child-delete-line-box-crash.html
fast/css/style-scoped/style-scoped-in-shadow.html
editing/shadow/selection-of-shadowroot.html
fast/dom/shadow/content-reprojection-order.html
fast/dom/shadow/distribution-attribute-modified.html
editing/shadow/breaking-editing-boundaries.html
fast/dom/shadow/content-element-renderers.html
fast/dom/shadow/content-after-style.html
fast/dom/shadow/content-element-includer.html
Comment 3 Shinya Kawanaka 2012-11-19 21:45:09 PST 
So many tests are failing... why? :-(
Comment 4 Shinya Kawanaka 2012-11-19 21:52:06 PST 
Created attachment 175137 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-11-19 22:10:05 PST 
Comment on attachment 175137 [details]
Patch for landing

Clearing flags on attachment: 175137

Committed r135251: <http://trac.webkit.org/changeset/135251>
Comment 6 WebKit Review Bot 2012-11-19 22:10:08 PST 
All reviewed patches have been landed.  Closing bug.