Bug 102754 - In CodeGenerator.pm we should rename $dataNode to $interface
Summary: In CodeGenerator.pm we should rename $dataNode to $interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 17:43 PST by Kentaro Hara
Modified: 2012-11-19 19:16 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.58 KB, patch)
2012-11-19 17:47 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-11-19 17:43:15 PST 
This is a final patch for the iteration.

$dataNode is misnamed. It should be $interface.
Comment 1 Kentaro Hara 2012-11-19 17:47:37 PST 
Created attachment 175101 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-19 19:05:22 PST 
Comment on attachment 175101 [details]
Patch

Attachment 175101 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14909435

New failing tests:
fast/dom/shadow/shadow-dom-event-dispatching.html
Comment 3 WebKit Review Bot 2012-11-19 19:16:02 PST 
Comment on attachment 175101 [details]
Patch

Clearing flags on attachment: 175101

Committed r135234: <http://trac.webkit.org/changeset/135234>
Comment 4 WebKit Review Bot 2012-11-19 19:16:05 PST 
All reviewed patches have been landed.  Closing bug.