Bug 102731 - [CSS Shaders] Do not clamp indirect array indices during CSS Shaders ANGLE validation pass
Summary: [CSS Shaders] Do not clamp indirect array indices during CSS Shaders ANGLE va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on:
Blocks: 71392
  Show dependency treegraph
 
Reported: 2012-11-19 16:09 PST by Max Vujovic
Modified: 2012-12-03 12:57 PST (History)
4 users (show)

See Also:


Attachments
Patch (8.93 KB, patch)
2012-11-19 16:44 PST, Max Vujovic
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2012-11-19 16:09:43 PST
Right now, we validate all shaders with the compile flag SH_CLAMP_INDIRECT_ARRAY_BOUNDS in ANGLEWebKitBridge. This inserts a GLSL function "webgl_int_clamp" in validated CSS shaders. However, when validated CSS shaders pass through ANGLE again at the GC3D level, ANGLE rejects them because they use the "webgl_" restricted prefix.

We should only pass the compile flag SH_CLAMP_INDIRECT_ARRAY_BOUNDS at the GC3D level.

Patch coming up.
Comment 1 Max Vujovic 2012-11-19 16:44:10 PST
Created attachment 175075 [details]
Patch
Comment 2 Max Vujovic 2012-11-30 16:58:43 PST
Thanks for the review, Dean! I'll land this on Monday, so I can watch the build bots.
Comment 3 WebKit Review Bot 2012-12-03 12:57:01 PST
Comment on attachment 175075 [details]
Patch

Clearing flags on attachment: 175075

Committed r136430: <http://trac.webkit.org/changeset/136430>
Comment 4 WebKit Review Bot 2012-12-03 12:57:04 PST
All reviewed patches have been landed.  Closing bug.