Bug 102729 - [CSS Exclusions] writing-mode:vertical-rl shape-inside tests are incorrectly configured
Summary: [CSS Exclusions] writing-mode:vertical-rl shape-inside tests are incorrectly ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 15:54 PST by Hans Muller
Modified: 2012-11-20 10:41 PST (History)
1 user (show)

See Also:


Attachments
shape-inside-polygon-rectangle.html screenshot (17.14 KB, image/png)
2012-11-19 15:54 PST, Hans Muller
no flags Details
Patch (3.71 KB, patch)
2012-11-20 07:45 PST, Hans Muller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2012-11-19 15:54:14 PST
Created attachment 175063 [details]
shape-inside-polygon-rectangle.html screenshot

The results of these ref-tests are manifestly incorrect, as can be seen in in the attached screenshot of LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html.  The following tests all share the same problem:

shape-inside-polygon-rectangle.html
shape-inside-vertical-text.html
shape-inside-multiple-blocks-vertical.html

The results are only obviously incorrect in the first case.  The source of the problem appears to be (just) a mixup between CSS padding, which lists top, right, bottom left, and the CSS top,left attributes that absolutely position the tests' border element.
Comment 1 Hans Muller 2012-11-20 07:45:24 PST
Created attachment 175220 [details]
Patch

Corrects shape-inside-polygon-rectangle.html and shape-inside-vertical-text.html.  The last test, shape-inside-multiple-blocks-vertical.html, was already correct.

The original tests were attempting to create a 2 pixel wide margin between the shape-inside text and the blue border outline.  The new versions of the tests use five pixels since that seemed a little simpler.
Comment 2 WebKit Review Bot 2012-11-20 10:41:15 PST
Comment on attachment 175220 [details]
Patch

Clearing flags on attachment: 175220

Committed r135296: <http://trac.webkit.org/changeset/135296>
Comment 3 WebKit Review Bot 2012-11-20 10:41:18 PST
All reviewed patches have been landed.  Closing bug.