Bug 102718 - Move tryUsePlatformCertificateInfoForChallenge from AuthenticationManager to PlatformCertificateInfo
Summary: Move tryUsePlatformCertificateInfoForChallenge from AuthenticationManager to ...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on: 102725
Blocks: 98537
  Show dependency tree / graph
 
Reported: 2012-11-19 14:51 PST by Brady Eidson
Modified: 2013-10-02 12:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (13.10 KB, patch)
2012-11-19 14:55 PST, Brady Eidson 		sam: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-11-19 14:51:13 PST 
Move tryUsePlatformCertificateInfoForChallenge from AuthenticationManager to PlatformCertificateInfo

It should also become a free function as it doesn't depend on being a member of any class.
Comment 1 Brady Eidson 2012-11-19 14:55:16 PST 
Created attachment 175046 [details]
Patch v1
Comment 2 Brady Eidson 2012-11-19 14:59:28 PST 
http://trac.webkit.org/changeset/135201
Comment 3 WebKit Review Bot 2012-11-19 15:34:55 PST 
Re-opened since this is blocked by bug 102725
Comment 4 EFL EWS Bot 2012-11-19 15:54:13 PST 
Comment on attachment 175046 [details]
Patch v1

Attachment 175046 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14913372
Comment 5 Early Warning System Bot 2012-11-19 16:00:42 PST 
Comment on attachment 175046 [details]
Patch v1

Attachment 175046 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14911360
Comment 6 Build Bot 2012-11-19 16:30:11 PST 
Comment on attachment 175046 [details]
Patch v1

Attachment 175046 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14905366
Comment 7 kov's GTK+ EWS bot 2012-11-19 16:30:55 PST 
Comment on attachment 175046 [details]
Patch v1

Attachment 175046 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14911367
Comment 8 Brady Eidson 2012-11-19 17:45:53 PST 
Wow.  Completely hosed this one.  Backing out.
Comment 9 Brady Eidson 2012-11-19 17:46:36 PST 
Already backed out, nm.  (I wish those messages went in the original bug, and not the bug that generated the rollout)
Comment 10 Brady Eidson 2012-11-19 17:46:59 PST 
(In reply to comment #9)
> Already backed out, nm.  (I wish those messages went in the original bug, and not the bug that generated the rollout)

Errr... original bug *in addition to* the bug generating the rollout.