Bug 102713 - IndexedDB: last setVersion excision batch
Summary: IndexedDB: last setVersion excision batch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks: 94972 105559
  Show dependency tree / graph
 
Reported: 2012-11-19 14:14 PST by David Grogan
Modified: 2012-12-20 11:50 PST (History)
4 users (show)

See Also:

Attachments
Patch (24.49 KB, patch)
2012-11-19 14:24 PST, David Grogan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-11-19 14:14:57 PST 
IndexedDB: last setVersion excision batch
Comment 1 David Grogan 2012-11-19 14:24:29 PST 
Created attachment 175041 [details]
Patch
Comment 2 David Grogan 2012-11-19 14:27:48 PST 
Josh, there are 2 deletions and 2 conversions. Could you take a look?

There are three outstanding tests but they have individual bugs.
Comment 3 Joshua Bell 2012-11-19 17:05:11 PST 
Comment on attachment 175041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175041&action=review

lgtm

> LayoutTests/storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js:36
> +    // In multi-process ports h2 can erroneously get a blocked event after

Weird - is that another case of wkbug.com/92674	"Delete requests sometimes receive two blocked events" ?
Comment 4 David Grogan 2012-11-19 17:18:58 PST 
Comment on attachment 175041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175041&action=review

>> LayoutTests/storage/indexeddb/resources/setversion-blocked-by-versionchange-close.js:36
>> +    // In multi-process ports h2 can erroneously get a blocked event after
> 
> Weird - is that another case of wkbug.com/92674    "Delete requests sometimes receive two blocked events" ?

Yeah. This request is for an open rather than a delete but it's the same behavior.
Comment 5 David Grogan 2012-11-19 17:19:22 PST 
Tony, could you review this?
Comment 6 WebKit Review Bot 2012-11-19 18:03:06 PST 
Comment on attachment 175041 [details]
Patch

Clearing flags on attachment: 175041

Committed r135223: <http://trac.webkit.org/changeset/135223>
Comment 7 WebKit Review Bot 2012-11-19 18:03:10 PST 
All reviewed patches have been landed.  Closing bug.