RESOLVED FIXED 102706
Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK) 
https://bugs.webkit.org/show_bug.cgi?id=102706
Summary Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK...
Pratik Solanki
Reported 2012-11-19 12:23:57 PST
With USE(NETWORK_CFDATA_ARRAY_CALLBACK), the code doesn't compile. We need ResourceBuffer::append(CFDataRef) and a few minor changes.
Attachments
Patch (2.58 KB, patch)
2012-11-19 12:42 PST, Pratik Solanki 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2012-11-19 12:42:40 PST
Created attachment 175027 [details] Patch
Alexey Proskuryakov
Comment 2 2012-11-19 15:49:34 PST
Looks good to me. Brady should take a look, since he's been actively working in this area of code recently.
Brent Fulgham
Comment 3 2012-11-19 17:32:15 PST
Comment on attachment 175027 [details] Patch Looks good to me. R=me.
Brady Eidson
Comment 4 2012-11-19 17:49:22 PST
Nothing wrong with this patch as a build fix. But fair warning - CFDATA_ARRAY_CALLBACK is somewhat incompatible with the IPC architecture of NetworkProcess mode, so we might have to revisit this type of thing in the future.
Pratik Solanki
Comment 5 2012-11-26 12:49:57 PST
Committed r135755: <http://trac.webkit.org/changeset/135755>
Note You need to log in before you can comment on or make changes to this bug.