Bug 102706 - Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK_CFDATA_ARRAY_CALLBACK)
Summary: Add ResourceBuffer::append(CFDataRef) to get code to compile with USE(NETWORK...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
Depends on:
Reported: 2012-11-19 12:23 PST by Pratik Solanki
Modified: 2012-11-26 12:49 PST (History)
6 users (show)

See Also:

Patch (2.58 KB, patch)
2012-11-19 12:42 PST, Pratik Solanki
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2012-11-19 12:23:57 PST
With USE(NETWORK_CFDATA_ARRAY_CALLBACK), the code doesn't compile. We need ResourceBuffer::append(CFDataRef) and a few minor changes.
Comment 1 Pratik Solanki 2012-11-19 12:42:40 PST
Created attachment 175027 [details]
Comment 2 Alexey Proskuryakov 2012-11-19 15:49:34 PST
Looks good to me. Brady should take a look, since he's been actively working in this area of code recently.
Comment 3 Brent Fulgham 2012-11-19 17:32:15 PST
Comment on attachment 175027 [details]

Looks good to me. R=me.
Comment 4 Brady Eidson 2012-11-19 17:49:22 PST
Nothing wrong with this patch as a build fix.

But fair warning - CFDATA_ARRAY_CALLBACK is somewhat incompatible with the IPC architecture of NetworkProcess mode, so we might have to revisit this type of thing in the future.
Comment 5 Pratik Solanki 2012-11-26 12:49:57 PST
Committed r135755: <http://trac.webkit.org/changeset/135755>