Bug 102704 - [EFL] Add fallback for WebkitTestRunner if opengl is not available.
Summary: [EFL] Add fallback for WebkitTestRunner if opengl is not available.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Viatcheslav Ostapenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 12:18 PST by Viatcheslav Ostapenko
Modified: 2012-11-19 21:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2012-11-19 12:32 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
Patch for landing (1.69 KB, patch)
2012-11-19 21:07 PST, Viatcheslav Ostapenko 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2012-11-19 12:18:14 PST 
Crash:
ASSERTION FAILED: m_ptr
/home/sl/work/webkit/Source/WTF/wtf/OwnPtr.h(72) : WTF::OwnPtr<T>::ValueType* WTF::OwnPtr<T>::operator->() const [with T = WTR::TestInvocation; WTF::OwnPtr<T>::PtrType = WTR::TestInvocation*; WTF::OwnPtr<T>::ValueType = WTR::TestInvocation]
1   0x80666be WTF::OwnPtr<WTR::TestInvocation>::operator->() const
2   0x8062c14 WTR::TestController::run()
3   0x8060a0d WTR::TestController::TestController(int, char const**)
4   0x8075b77 main
5   0xb05304d3 __libc_start_main
6   0x805f611
Comment 1 Viatcheslav Ostapenko 2012-11-19 12:32:01 PST 
Created attachment 175024 [details]
Patch
Comment 2 Yael 2012-11-19 14:45:53 PST 
LGTM
Comment 3 Laszlo Gombos 2012-11-19 17:01:08 PST 
Comment on attachment 175024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175024&action=review

> Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp:36
> +    ecoreEvas = ecore_evas_new(engine, 0, 0, 800, 600, 0);

I would add a comment here // Graceful fallback to software rendering if evas_gl engine is not available.
Comment 4 Viatcheslav Ostapenko 2012-11-19 21:07:48 PST 
Created attachment 175129 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-11-19 21:35:24 PST 
Comment on attachment 175129 [details]
Patch for landing

Clearing flags on attachment: 175129

Committed r135246: <http://trac.webkit.org/changeset/135246>
Comment 6 WebKit Review Bot 2012-11-19 21:35:28 PST 
All reviewed patches have been landed.  Closing bug.