Bug 102690 – [V8] Workers cannot make xhr requests in the presence of extensions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dan Carney]

[V8] Workers cannot make xhr requests in the presence of extensions

[Dan Carney]

Created attachment 174988 [details]
Patch

[Dan Carney]

This deserves a regression test, but I had to leave work. I will add it tomorrow.

Comment on attachment 174988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174988&action=review

> Source/WebCore/ChangeLog:9
> +        V8DOMWindowShell::getEntered

can you elaborate a bit on what the problem is and how you solve it?

> Source/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:58
> +    if (isMainThread()) {

isn't the point that workers can't have extensions (= isolated worlds) in the first place? Shouldn't the check then be something like

if (context->isDocument()) {
    ASSERT(isMainThread());
    ... 
} else {
    ASSERT(context->isWorkerContext());
    securityOrigin = static_cast<WorkerContext*>(context)->topOrigin();
}

[Adam Barth]

Comment on attachment 174988 [details]
Patch

This is fixed in my get entered patch that hasn't landed yet.  Rather than calling isMainThread, which is slow, we should asks the ScriptExecutionContext if it is a document

[Dan Carney]

Comment on attachment 174988 [details]
Patch

this was fixed in https://bugs.webkit.org/show_bug.cgi?id=102156

[Adam Barth]

Sorry for the delay in landing my patch.