Bug 102674 - [EFL][WK2] Remove unnecessary #include in API test
Summary: [EFL][WK2] Remove unnecessary #include in API test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 04:29 PST by Jinwoo Song
Modified: 2012-11-20 21:32 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.31 KB, patch)
2012-11-19 04:32 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Patch (16.50 KB, patch)
2012-11-20 04:47 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2012-11-19 04:29:16 PST 
Removed #include <gtest/gtest.h> line in the API test cases as EWK2UnitTestBase.h already included it.
Comment 1 Jinwoo Song 2012-11-19 04:32:44 PST 
Created attachment 174952 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-11-19 07:36:02 PST 
LGTM.
Comment 3 Laszlo Gombos 2012-11-19 11:42:10 PST 
It seems to me that there are other header files (e.g. EWebKit2.h) that are included in EWK2UnitTestBase.h as well. Why is <gtest.h> singled out? 

I think for consistency either all duplicated should be removed or leave it as it is.
Comment 4 Jinwoo Song 2012-11-20 00:57:00 PST 
(In reply to comment #3)
> It seems to me that there are other header files (e.g. EWebKit2.h) that are included in EWK2UnitTestBase.h as well. Why is <gtest.h> singled out? 
> 
> I think for consistency either all duplicated should be removed or leave it as it is.

I'll removed other duplicated header files and upload a new patch. :)
Comment 5 Jinwoo Song 2012-11-20 04:47:37 PST 
Created attachment 175191 [details]
Patch
Comment 6 Laszlo Gombos 2012-11-20 21:15:12 PST 
Comment on attachment 175191 [details]
Patch

r=me.
Comment 7 WebKit Review Bot 2012-11-20 21:32:46 PST 
Comment on attachment 175191 [details]
Patch

Clearing flags on attachment: 175191

Committed r135349: <http://trac.webkit.org/changeset/135349>
Comment 8 WebKit Review Bot 2012-11-20 21:32:50 PST 
All reviewed patches have been landed.  Closing bug.