Bug 102668 - [GTK] Test /webkit2/WebKitWebView/create-ready-close is failing after r134586
Summary: [GTK] Test /webkit2/WebKitWebView/create-ready-close is failing after r134586
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2012-11-19 02:22 PST by Carlos Garcia Campos
Modified: 2012-11-19 03:23 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2012-11-19 02:29 PST, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-11-19 02:22:37 PST 
Change in r134586 is not the problem, it indeed fixes the FIXME we have in the tests. The problem is that we were assuming that when no geometry is given to window.open() the default window rect is empty. This is not true anymore after r134586.
Comment 1 Carlos Garcia Campos 2012-11-19 02:29:16 PST 
Created attachment 174927 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-19 02:32:15 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2012-11-19 03:23:27 PST 
Committed r135135: <http://trac.webkit.org/changeset/135135>