RESOLVED FIXED 102661
Move in animation should be disabled until the calendar picker is loaded. 
https://bugs.webkit.org/show_bug.cgi?id=102661
Summary Move in animation should be disabled until the calendar picker is loaded.
Keishi Hattori
Reported 2012-11-19 01:29:56 PST
<input type=week value="2012-W01">
Attachments
Patch (2.46 KB, patch)
2012-11-19 02:52 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-11-19 02:52:45 PST
Created attachment 174930 [details] Patch
Kent Tamura
Comment 2 2012-11-19 18:33:04 PST
Comment on attachment 174930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174930&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:1317 > + if (this.picker.isPreparing) > + return; I feel Introducing a new flag is inelegant though it's ok if there are no better ways.
Keishi Hattori
Comment 3 2012-11-19 20:05:42 PST
(In reply to comment #2) > (From update of attachment 174930 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174930&action=review > > > Source/WebCore/Resources/pagepopups/calendarPicker.js:1317 > > + if (this.picker.isPreparing) > > + return; > > I feel Introducing a new flag is inelegant though it's ok if there are no better ways. We only ever need to disable animation during load so this is cleaner than adding an argument to selectRange and we might use this flag when adding other animations.
WebKit Review Bot
Comment 4 2012-11-19 20:20:32 PST
Comment on attachment 174930 [details] Patch Clearing flags on attachment: 174930 Committed r135238: <http://trac.webkit.org/changeset/135238>
WebKit Review Bot
Comment 5 2012-11-19 20:20:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.