Bug 102658 – Add PROXIMITY_EVENTS feature

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kihong Kwon]

Add PROXIMITY_EVENTS feature to all ports.

[Kihong Kwon]

Created attachment 174922 [details]
Patch

[Build Bot]

Comment on attachment 174922 [details]
Patch

Attachment 174922 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14911141

[Kihong Kwon]

Created attachment 174933 [details]
Patch

[Kentaro Hara]

Comment on attachment 174933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174933&action=review

Looks OK. Did you locally confirm the behavior with PROXIMITY_EVENTS enabled?

> Source/JavaScriptCore/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to xcode project for JavaScriptCore.

Typo: feature

> Source/WebCore/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to xcode project for WebCorei and GNU make.

Typo: feature
Typo: WebCore

> Source/WebKit/chromium/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to chromium port.

Typo: feature

> Source/WebKit/mac/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to xcode project for WebKit.

Ditto.

> Source/WebKit2/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to xcode project for WebKit2.

Ditto.

> Tools/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to FeatureList and qmake.

Ditto.

> ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to cmake.

Ditto.

> WebKitLibraries/ChangeLog:8
> +        Add PROXIMITY_EVENTS featue to win and win-cairo prot.

Ditto.

[Kihong Kwon]

(In reply to comment #4)
> (From update of attachment 174933 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174933&action=review
> 
> Looks OK. Did you locally confirm the behavior with PROXIMITY_EVENTS enabled?

Yes, I already checked that.
And I will fix all my typo.
Thank you.

[Kentaro Hara]

Comment on attachment 174933 [details]
Patch

OK, thanks for the fix!

[Kihong Kwon]

Created attachment 174943 [details]
Patch

[Kihong Kwon]

Comment on attachment 174943 [details]
Patch

Thank you for reviewing. haraken. :)

[WebKit Review Bot]

Comment on attachment 174943 [details]
Patch

Clearing flags on attachment: 174943

Committed r135159: <http://trac.webkit.org/changeset/135159>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Roger Fong]

I noticed that in this patch the feature defines flag for windows is set to false (Value = "")
Is the proximity events feature not supposed to work on Windows?

I also noticed that there are 9 new failing proximity tests 
http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r139050%20(31331)/results.html

They still fail if I enable the feature.

[Kihong Kwon]

(In reply to comment #11)
> I noticed that in this patch the feature defines flag for windows is set to false (Value = "")
> Is the proximity events feature not supposed to work on Windows?
> 
> I also noticed that there are 9 new failing proximity tests 
> http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r139050%20(31331)/results.html
> 
> They still fail if I enable the feature.

Proximity event test cases can be passed on the efl wk2 until now.
If Windows port support proximity events, someone need to implement window port layer for Proximity Events.