Bug 102636 - Add myself to committers.py
Summary: Add myself to committers.py
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 102638
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-18 20:01 PST by Vivek Galatage
Modified: 2012-11-18 22:16 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2012-11-18 20:15 PST, Vivek Galatage
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2012-11-18 20:01:38 PST
Add myself to committers.py
Comment 1 Vivek Galatage 2012-11-18 20:15:16 PST
Created attachment 174882 [details]
Patch
Comment 2 Laszlo Gombos 2012-11-18 20:51:18 PST
Comment on attachment 174882 [details]
Patch

r=me.
Comment 3 WebKit Review Bot 2012-11-18 20:54:03 PST
Comment on attachment 174882 [details]
Patch

Rejecting attachment 174882 [details] from commit-queue.

vivek.vg@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Review Bot 2012-11-18 21:11:51 PST
Comment on attachment 174882 [details]
Patch

Clearing flags on attachment: 174882

Committed r135104: <http://trac.webkit.org/changeset/135104>
Comment 5 WebKit Review Bot 2012-11-18 21:11:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2012-11-18 21:13:19 PST
As a committer, you should be careful enough to read a comment before the block you change. Changes to committers.py do not need review.

Also, a new committer should make this modification manually, to prove actually having the privilege.
Comment 7 WebKit Review Bot 2012-11-18 21:16:21 PST
Re-opened since this is blocked by bug 102638
Comment 8 Eric Seidel (no email) 2012-11-18 22:16:00 PST
:shrug:  It's nice to do that, but I believe we have several committers who have never even committed manually. :)  I doubt this was worth the rollout churn.