Bug 102636 – Add myself to committers.py

• Status: RESOLVED
• Resolution: INVALID
• Component: Tools / Tests

[Vivek Galatage]

Add myself to committers.py

[Vivek Galatage]

Created attachment 174882 [details]
Patch

[Laszlo Gombos]

Comment on attachment 174882 [details]
Patch

r=me.

[WebKit Review Bot]

Comment on attachment 174882 [details]
Patch

Rejecting attachment 174882 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 174882 [details]
Patch

Clearing flags on attachment: 174882

Committed r135104: <http://trac.webkit.org/changeset/135104>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

As a committer, you should be careful enough to read a comment before the block you change. Changes to committers.py do not need review.

Also, a new committer should make this modification manually, to prove actually having the privilege.

[WebKit Review Bot]

Re-opened since this is blocked by bug 102638

[Eric Seidel (no email)]

:shrug:  It's nice to do that, but I believe we have several committers who have never even committed manually. :)  I doubt this was worth the rollout churn.