WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
102633
Visual C++ Express 2005 can not build WebKit any more
https://bugs.webkit.org/show_bug.cgi?id=102633
Summary
Visual C++ Express 2005 can not build WebKit any more
Takashi Toyoshima
Reported
2012-11-18 19:37:17 PST
Latest solution file contains a new feature, solution folder, which is not supported by Express version. I'm not sure this is only the problem, but apparently it causes problem to open solution file by Express 2005. Here is a log I ran build-webkit. =============================================================================================================================== $ ./Tools/Script/build-webkit --release WebKitSupportLibrary is up-to-date. Building results into: /cygdrive/d/src/chromium/src/third_party/WebKit/WebKitBuild WEBKITOUTPUTDIR is set to: D:\src\chromium\src\third_party\WebKit\WebKitBuild WEBKITLIBRARIESDIR is set to: D:\src\chromium\src\third_party\WebKit\WebKitLibraries\win /cygdrive/c/Program Files (x86)/Microsoft Visual Studio 8/Common7/IDE/VCExpress.exe win\WebKit.vcproj\WebKit.sln /build Release Traceback (most recent call last): File "Tools/Scripts/print-vse-failure-logs", line 113, in <module> PrintVisualStudioExpressLogs().main() File "Tools/Scripts/print-vse-failure-logs", line 102, in main build_log_paths = self._sort_buildlogs(self._find_buildlogs(self._obj_directory())) File "Tools/Scripts/print-vse-failure-logs", line 67, in _sort_buildlogs build_order = self._build_order() File "Tools/Scripts/print-vse-failure-logs", line 60, in _build_order sln_path = os.path.join(scm.find_checkout_root(), "WebKit", "win", "WebKit.vcproj", "WebKit.sln") AttributeError: 'module' object has no attribute 'find_checkout_root' ===== BUILD FAILED ====== Please ensure you have run Tools/Scripts/update-webkit to install dependencies. You can view build errors by checking the BuildLog.htm files located at: /cygdrive/d/src/chromium/src/third_party/WebKit/WebKitBuild/obj/<project>/<config>. =============================================================================================================================== VCExpress.exe did nothing and returned non-zero value. Traceback is caused from another bug,
https://bugs.webkit.org/show_bug.cgi?id=74944
It just fails to show build log. Also, when I'm going to open the solution file from IDE, it says the opening solution contains unsupported solution folders, then could not build some sub projects.
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2012-11-19 23:25:56 PST
> Latest solution file contains a new feature, solution folder, which is not supported by Express version.
I remember seeing a lot of these warnings when I had VC Express a few years ago, but they didn't affect building. CC'ing dpranke, because find_checkout_root is related to some work he did recently.
Dirk Pranke
Comment 2
2012-11-20 13:13:48 PST
I think print-vse-failure-logs has just been busted for a long time. That code needs to be updated to something like Host().scm().find_checkout_root() or WebKitFinder().path_from_webkit_base(...) .
Takashi Toyoshima
Comment 3
2012-11-21 20:03:45 PST
print-vse-failure-logs is called after build is finished. So, the problem that Dirk said is not the root of this build problem and the issue of print-vse-failure-logs is filed as separated entry at
https://bugs.webkit.org/show_bug.cgi?id=74944
. VCExpress.exe exit in a seconds without any message.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug