RESOLVED FIXED 102632
Remove non-existent directories from the make system 
https://bugs.webkit.org/show_bug.cgi?id=102632
Summary Remove non-existent directories from the make system
Laszlo Gombos
Reported 2012-11-18 19:08:28 PST
Symbian support has been removed from the tree a while ago - see http://trac.webkit.org/changeset/97557. I found a few places where Symbian-related files are still referenced (mostly just to filter them out). This is now dead code and should be removed.
Attachments
1st try (6.74 KB, patch)
2012-11-18 19:38 PST, Laszlo Gombos 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
for cq - fixed the author in Source/WebCore/ChangeLog (6.74 KB, patch)
2012-11-18 21:30 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2012-11-18 19:38:24 PST
Created attachment 174878 [details] 1st try
WebKit Review Bot
Comment 2 2012-11-18 20:52:02 PST
Comment on attachment 174878 [details] 1st try Rejecting attachment 174878 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/14909043
WebKit Review Bot
Comment 3 2012-11-18 20:57:13 PST
Comment on attachment 174878 [details] 1st try Rejecting attachment 174878 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: http://queues.webkit.org/results/14910043
Laszlo Gombos
Comment 4 2012-11-18 21:30:44 PST
Created attachment 174885 [details] for cq - fixed the author in Source/WebCore/ChangeLog
WebKit Review Bot
Comment 5 2012-11-18 21:47:33 PST
Comment on attachment 174885 [details] for cq - fixed the author in Source/WebCore/ChangeLog Clearing flags on attachment: 174885 Committed r135109: <http://trac.webkit.org/changeset/135109>
WebKit Review Bot
Comment 6 2012-11-18 21:47:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.