Bug 102632 - Remove non-existent directories from the make system
Summary: Remove non-existent directories from the make system
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-18 19:08 PST by Laszlo Gombos
Modified: 2012-11-18 21:47 PST (History)
6 users (show)

See Also:


Attachments
1st try (6.74 KB, patch)
2012-11-18 19:38 PST, Laszlo Gombos
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
for cq - fixed the author in Source/WebCore/ChangeLog (6.74 KB, patch)
2012-11-18 21:30 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2012-11-18 19:08:28 PST
Symbian support has been removed from the tree a while ago - see http://trac.webkit.org/changeset/97557. I found a few places where Symbian-related files are still referenced (mostly just to filter them out). This is now dead code and should be removed.
Comment 1 Laszlo Gombos 2012-11-18 19:38:24 PST
Created attachment 174878 [details]
1st try
Comment 2 WebKit Review Bot 2012-11-18 20:52:02 PST
Comment on attachment 174878 [details]
1st try

Rejecting attachment 174878 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/14909043
Comment 3 WebKit Review Bot 2012-11-18 20:57:13 PST
Comment on attachment 174878 [details]
1st try

Rejecting attachment 174878 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ueue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://queues.webkit.org/results/14910043
Comment 4 Laszlo Gombos 2012-11-18 21:30:44 PST
Created attachment 174885 [details]
for cq - fixed the author in Source/WebCore/ChangeLog
Comment 5 WebKit Review Bot 2012-11-18 21:47:33 PST
Comment on attachment 174885 [details]
for cq - fixed the author in Source/WebCore/ChangeLog

Clearing flags on attachment: 174885

Committed r135109: <http://trac.webkit.org/changeset/135109>
Comment 6 WebKit Review Bot 2012-11-18 21:47:37 PST
All reviewed patches have been landed.  Closing bug.