RESOLVED FIXED 102630
JSC should have more logging in structure-related code 
https://bugs.webkit.org/show_bug.cgi?id=102630
Summary JSC should have more logging in structure-related code
Filip Pizlo
Reported 2012-11-18 18:23:16 PST
Patch forthcoming.
Attachments
the patch (7.10 KB, patch)
2012-11-18 18:29 PST, Filip Pizlo 		simon.fraser: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-18 18:29:13 PST
Created attachment 174875 [details] the patch
Simon Fraser (smfr)
Comment 2 2012-11-18 18:34:57 PST
Comment on attachment 174875 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=174875&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2202 > + JSCell* origin = m_dfgData->transitions[i].m_codeOrigin.get(); > + JSCell* from = m_dfgData->transitions[i].m_from.get(); > + JSCell* to = m_dfgData->transitions[i].m_to.get(); You could use a local reference to m_dfgData->transitions[i] to avoid getting it thrice.
Filip Pizlo
Comment 3 2012-11-18 18:52:50 PST
(In reply to comment #2) > (From update of attachment 174875 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174875&action=review > > > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2202 > > + JSCell* origin = m_dfgData->transitions[i].m_codeOrigin.get(); > > + JSCell* from = m_dfgData->transitions[i].m_from.get(); > > + JSCell* to = m_dfgData->transitions[i].m_to.get(); > > You could use a local reference to m_dfgData->transitions[i] to avoid getting it thrice. Good point, that would be clearer. THanks!
Build Bot
Comment 4 2012-11-18 18:56:25 PST
Comment on attachment 174875 [details] the patch Attachment 174875 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14907014
Filip Pizlo
Comment 5 2012-11-18 18:58:27 PST
Landed in http://trac.webkit.org/changeset/135097
Filip Pizlo
Comment 6 2012-11-18 18:59:35 PST
Windows build fix landed in http://trac.webkit.org/changeset/135099
Note You need to log in before you can comment on or make changes to this bug.