Bug 102630 - JSC should have more logging in structure-related code
Summary: JSC should have more logging in structure-related code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-18 18:23 PST by Filip Pizlo
Modified: 2012-11-18 18:59 PST (History)
7 users (show)

See Also:

Attachments
the patch (7.10 KB, patch)
2012-11-18 18:29 PST, Filip Pizlo 		simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-18 18:23:16 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-11-18 18:29:13 PST 
Created attachment 174875 [details]
the patch
Comment 2 Simon Fraser (smfr) 2012-11-18 18:34:57 PST 
Comment on attachment 174875 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174875&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:2202
> +                JSCell* origin = m_dfgData->transitions[i].m_codeOrigin.get();
> +                JSCell* from = m_dfgData->transitions[i].m_from.get();
> +                JSCell* to = m_dfgData->transitions[i].m_to.get();

You could use a local reference to m_dfgData->transitions[i] to avoid getting it thrice.
Comment 3 Filip Pizlo 2012-11-18 18:52:50 PST 
(In reply to comment #2)
> (From update of attachment 174875 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174875&action=review
> 
> > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2202
> > +                JSCell* origin = m_dfgData->transitions[i].m_codeOrigin.get();
> > +                JSCell* from = m_dfgData->transitions[i].m_from.get();
> > +                JSCell* to = m_dfgData->transitions[i].m_to.get();
> 
> You could use a local reference to m_dfgData->transitions[i] to avoid getting it thrice.

Good point, that would be clearer.  THanks!
Comment 4 Build Bot 2012-11-18 18:56:25 PST 
Comment on attachment 174875 [details]
the patch

Attachment 174875 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14907014
Comment 5 Filip Pizlo 2012-11-18 18:58:27 PST 
Landed in http://trac.webkit.org/changeset/135097
Comment 6 Filip Pizlo 2012-11-18 18:59:35 PST 
Windows build fix landed in http://trac.webkit.org/changeset/135099