Bug 102628 - min/max/step support for calendar picker on datetime/datetime-local
Summary: min/max/step support for calendar picker on datetime/datetime-local
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 103817
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-18 18:10 PST by Kunihiko Sakamoto
Modified: 2012-12-01 11:56 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.94 KB, patch)
2012-11-18 18:26 PST, Kunihiko Sakamoto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kunihiko Sakamoto 2012-11-18 18:10:39 PST
Calendar picker for datetime/datetime-local should gray out dates with no allowed values.

For example, <input type=datetime min="2012-11-14T12:00Z" step="129600"> allows following values:

2012-11-14T12:00Z
2012-11-16T00:00Z
2012-11-17T12:00Z
2012-11-19T00:00Z
...

Calendar picker for this input should accept only 2012-11-14, 2012-11-16, 2012-11-17, 2012-11-19, and so on.
Comment 1 Kunihiko Sakamoto 2012-11-18 18:26:49 PST
Created attachment 174874 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-18 19:39:56 PST
Comment on attachment 174874 [details]
Patch

Attachment 174874 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14904032

New failing tests:
inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Comment 3 Kent Tamura 2012-11-18 20:08:27 PST
Comment on attachment 174874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174874&action=review

> LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html:20
> +    debug("Step without min or max.");

nit: Please be consistent for quotation mark usage. Many code in this file use single quotes, but some parts use double quotes.
Comment 4 WebKit Review Bot 2012-11-18 21:51:23 PST
Comment on attachment 174874 [details]
Patch

Clearing flags on attachment: 174874

Committed r135110: <http://trac.webkit.org/changeset/135110>
Comment 5 WebKit Review Bot 2012-11-18 21:51:27 PST
All reviewed patches have been landed.  Closing bug.