Bug 102613 - [GTK] REGRESSION(r134955): Plugins are broken due to unresolved symbol in plugin process
Summary: [GTK] REGRESSION(r134955): Plugins are broken due to unresolved symbol in plu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2012-11-18 10:06 PST by Carlos Garcia Campos
Modified: 2012-11-19 23:37 PST (History)
3 users (show)

See Also:

Attachments
Fix the build (1.11 KB, patch)
2012-11-19 12:37 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (1.14 KB, patch)
2012-11-19 13:30 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-11-18 10:06:44 PST 
See http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/31084/steps/API%20tests/logs/stdio plugins tests started to fail. The problem is an unresolved symbol in plugin process see:

$ Programs/WebKitPluginProcess -scanPlugin TestNetscapePlugin/libtestnetscapeplugin.la 
Programs/.libs/lt-WebKitPluginProcess: symbol lookup error: Programs/.libs/lt-WebKitPluginProcess: undefined symbol: SECRET_SCHEMA_COMPAT_NETWORK
Comment 1 Martin Robinson 2012-11-19 08:32:06 PST 
Thanks for reporting this. We probably just need to add LIBSECRET_LIBS to Programs_WebKitPluginProcess_LDADD.
Comment 2 Martin Robinson 2012-11-19 12:37:07 PST 
Created attachment 175026 [details]
Fix the build
Comment 3 WebKit Review Bot 2012-11-19 13:25:15 PST 
Comment on attachment 175026 [details]
Fix the build

Rejecting attachment 175026 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14905315
Comment 4 Martin Robinson 2012-11-19 13:30:42 PST 
Created attachment 175035 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-19 14:10:17 PST 
Comment on attachment 175035 [details]
Patch

Clearing flags on attachment: 175035

Committed r135195: <http://trac.webkit.org/changeset/135195>
Comment 6 WebKit Review Bot 2012-11-19 14:10:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Carlos Garcia Campos 2012-11-19 23:37:57 PST 
Thanks!