Bug 102612 – [chromium] add WebCursorInfo::imageScaleFactor

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Rick Byers]

Splitting the chromium API change out from bug 99493 in order to decouple the webkit and chromium sides of this work.

[Rick Byers]

Created attachment 174847 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Adam Barth]

Comment on attachment 174847 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174847&action=review

> Source/WebKit/chromium/src/WebCursorInfo.cpp:44
> +    imageScaleFactor = 1;

You should initialize this variable in an initializer list, like you've done in the header.

[Rick Byers]

Created attachment 174849 [details]
Patch

[Rick Byers]

(In reply to comment #3)
> (From update of attachment 174847 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174847&action=review
> 
> > Source/WebKit/chromium/src/WebCursorInfo.cpp:44
> > +    imageScaleFactor = 1;
> 
> You should initialize this variable in an initializer list, like you've done in the header.

Thanks.  I moved the initialization of all variables in this ctor to an initializer list in order to be consistent.

[Adam Barth]

Comment on attachment 174849 [details]
Patch

great

[Build Bot]

Comment on attachment 174849 [details]
Patch

Attachment 174849 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14893089

New failing tests:
inspector-protocol/nmi-webaudio.html

[WebKit Review Bot]

Comment on attachment 174849 [details]
Patch

Clearing flags on attachment: 174849

Committed r135076: <http://trac.webkit.org/changeset/135076>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.