Bug 102588 - Remove 8-bit related assertion from NetscapePluginModuleX11.
Summary: Remove 8-bit related assertion from NetscapePluginModuleX11.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-17 07:36 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2012-11-19 07:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2012-11-17 07:38 PST, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-11-17 07:36:40 PST 
Remove 8-bit related assertion from NetscapePluginModuleX11.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-11-17 07:38:38 PST 
Created attachment 174818 [details]
Patch
Comment 2 Balazs Kelemen 2012-11-17 07:42:16 PST 
Oops, I forgot to remove the assert :-) LGTM.
Comment 3 WebKit Review Bot 2012-11-17 19:41:21 PST 
Comment on attachment 174818 [details]
Patch

Rejecting attachment 174818 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
2 diffs from patch file(s).
patching file Source/WebKit2/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp
Hunk #1 FAILED at 160.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Andreas Kl..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14859936
Comment 4 Csaba Osztrogonác 2012-11-19 07:15:24 PST 
Landed in r135057.