Bug 102582 - [Soup] CredentialStorage should only be used for HTTP-family requests
Summary: [Soup] CredentialStorage should only be used for HTTP-family requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-16 22:03 PST by Martin Robinson
Modified: 2012-11-17 00:04 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.96 KB, patch)
2012-11-16 22:25 PST, Martin Robinson 		gustavo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2012-11-16 22:03:21 PST 
This is causing assertion failures on the debug bots.
Comment 1 Martin Robinson 2012-11-16 22:25:42 PST 
Created attachment 174808 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-11-16 23:12:51 PST 
Comment on attachment 174808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174808&action=review

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:873
> +    if (!d->m_user.isEmpty() || !d->m_pass.isEmpty()) {
> +        // If credentials were specified for this request, add them to the url,
> +        // so that they will be passed to NetworkRequest.
> +        KURL urlWithCredentials(firstRequest().url());
> +        urlWithCredentials.setUser(d->m_user);
> +        urlWithCredentials.setPass(d->m_pass);
> +        d->m_firstRequest.setURL(urlWithCredentials);
> +    }

This is a left over, as we discussed on IRC, otherwise looks good!
Comment 3 Martin Robinson 2012-11-17 00:04:03 PST 
Committed r135040: <http://trac.webkit.org/changeset/135040>