DeviceOrientationController and DeviceMotionController have almost same structure. Therefore DeviceController which is extracted as parent class of them is added. In this patch, I apply DeviceController as parent class of DeviceMotionController.
Created attachment 174802 [details] Patch
Comment on attachment 174802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review Looks reasonable to me but I'm not familiar with this area. I'd be happy if morrita@ could take a look. > Source/WebCore/ChangeLog:11 > + Therfore duplicated implementation can be removed. Typo: Therefore
Comment on attachment 174802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review Looks good. Please fix some nit-picky bits on ChangeLog before landing. > Source/WebCore/ChangeLog:8 > + DeviceController need to be applied as parent class of DeviceMotionController s/need/needs/
Created attachment 175125 [details] Patch
Comment on attachment 175125 [details] Patch Thank you for your review, morrita. :)
Comment on attachment 175125 [details] Patch Clearing flags on attachment: 175125 Committed r135268: <http://trac.webkit.org/changeset/135268>
All reviewed patches have been landed. Closing bug.