Bug 102578 - Apply DeviceController as parent class of DeviceMotionController.
Summary: Apply DeviceController as parent class of DeviceMotionController.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kihong Kwon
URL:
Keywords:
Depends on: 96894
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-16 20:50 PST by Kihong Kwon
Modified: 2012-11-20 03:10 PST (History)
4 users (show)

See Also:


Attachments
Patch (14.54 KB, patch)
2012-11-16 21:15 PST, Kihong Kwon
no flags Details | Formatted Diff | Diff
Patch (14.56 KB, patch)
2012-11-19 20:07 PST, Kihong Kwon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kihong Kwon 2012-11-16 20:50:54 PST
DeviceOrientationController and DeviceMotionController have almost same structure.
Therefore DeviceController which is extracted as parent class of them is added.
In this patch, I apply DeviceController as parent class of DeviceMotionController.
Comment 1 Kihong Kwon 2012-11-16 21:15:01 PST
Created attachment 174802 [details]
Patch
Comment 2 Kentaro Hara 2012-11-19 03:25:33 PST
Comment on attachment 174802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review

Looks reasonable to me but I'm not familiar with this area. I'd be happy if morrita@ could take a look.

> Source/WebCore/ChangeLog:11
> +        Therfore duplicated implementation can be removed.

Typo: Therefore
Comment 3 Hajime Morrita 2012-11-19 18:49:16 PST
Comment on attachment 174802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174802&action=review

Looks good. Please fix some nit-picky bits on ChangeLog before landing.

> Source/WebCore/ChangeLog:8
> +        DeviceController need to be applied as parent class of DeviceMotionController

s/need/needs/
Comment 4 Kihong Kwon 2012-11-19 20:07:59 PST
Created attachment 175125 [details]
Patch
Comment 5 Kihong Kwon 2012-11-20 03:06:26 PST
Comment on attachment 175125 [details]
Patch

Thank you for your review, morrita. :)
Comment 6 WebKit Review Bot 2012-11-20 03:10:05 PST
Comment on attachment 175125 [details]
Patch

Clearing flags on attachment: 175125

Committed r135268: <http://trac.webkit.org/changeset/135268>
Comment 7 WebKit Review Bot 2012-11-20 03:10:08 PST
All reviewed patches have been landed.  Closing bug.