Bug 102567 – Set task priority of WebKit2 processes to zero on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kiran Muppala]

Set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS on Mac, to override automatic assignment by the kernel.  This is a temporary fix until WebKit2 processes can better manage their own priority.

[Kiran Muppala]

<rdar://problem/12721417>

[Kiran Muppala]

Created attachment 174775 [details]
Patch

[Kiran Muppala]

Created attachment 174780 [details]
Patch

[Mark Rowe (bdash)]

Comment on attachment 174780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174780&action=review

> Source/WebKit2/ChangeLog:9
> +        Explicitly set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS, to
> +        override automatic priority determination by the system.

This doesn't match how the code works. PRIO_DARWIN_PROCESS specifies what you're changing the priority of. In this case, you're setting the priority of the current process to 0.

[Kiran Muppala]

(In reply to comment #4)
> (From update of attachment 174780 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174780&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Explicitly set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS, to
> > +        override automatic priority determination by the system.
> 
> This doesn't match how the code works. PRIO_DARWIN_PROCESS specifies what you're changing the priority of. In this case, you're setting the priority of the current process to 0.

Yeah you are right.  Fixing the bug title and change log.

[Kiran Muppala]

Created attachment 174784 [details]
Patch

[WebKit Review Bot]

Comment on attachment 174784 [details]
Patch

Clearing flags on attachment: 174784

Committed r135020: <http://trac.webkit.org/changeset/135020>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.