Bug 102567 - Set task priority of WebKit2 processes to zero on Mac
Summary: Set task priority of WebKit2 processes to zero on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kiran Muppala
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-16 16:00 PST by Kiran Muppala
Modified: 2012-11-16 17:34 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.05 KB, patch)
2012-11-16 16:05 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2012-11-16 16:34 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (3.33 KB, patch)
2012-11-16 16:58 PST, Kiran Muppala
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kiran Muppala 2012-11-16 16:00:08 PST
Set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS on Mac, to override automatic assignment by the kernel.  This is a temporary fix until WebKit2 processes can better manage their own priority.
Comment 1 Kiran Muppala 2012-11-16 16:00:54 PST
<rdar://problem/12721417>
Comment 2 Kiran Muppala 2012-11-16 16:05:33 PST
Created attachment 174775 [details]
Patch
Comment 3 Kiran Muppala 2012-11-16 16:34:13 PST
Created attachment 174780 [details]
Patch
Comment 4 Mark Rowe (bdash) 2012-11-16 16:54:20 PST
Comment on attachment 174780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174780&action=review

> Source/WebKit2/ChangeLog:9
> +        Explicitly set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS, to
> +        override automatic priority determination by the system.

This doesn't match how the code works. PRIO_DARWIN_PROCESS specifies what you're changing the priority of. In this case, you're setting the priority of the current process to 0.
Comment 5 Kiran Muppala 2012-11-16 16:57:34 PST
(In reply to comment #4)
> (From update of attachment 174780 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174780&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Explicitly set task priority of WebKit2 processes to PRIO_DARWIN_PROCESS, to
> > +        override automatic priority determination by the system.
> 
> This doesn't match how the code works. PRIO_DARWIN_PROCESS specifies what you're changing the priority of. In this case, you're setting the priority of the current process to 0.

Yeah you are right.  Fixing the bug title and change log.
Comment 6 Kiran Muppala 2012-11-16 16:58:52 PST
Created attachment 174784 [details]
Patch
Comment 7 WebKit Review Bot 2012-11-16 17:34:55 PST
Comment on attachment 174784 [details]
Patch

Clearing flags on attachment: 174784

Committed r135020: <http://trac.webkit.org/changeset/135020>
Comment 8 WebKit Review Bot 2012-11-16 17:34:58 PST
All reviewed patches have been landed.  Closing bug.