IndexedDB: setVersion excision batch 10
Created attachment 174766 [details] Patch
Josh, could you look at this? There are 6 removals and 2 conversions here. There are 6 tests left. 1 fails an assert - bug 101810. The last 5 are going to be a bear to convert or deleted. So... close...
Attachment 174766 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/stor..." exit_code: 1 LayoutTests/ChangeLog:47: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 174768 [details] Patch Fix style in changelog
Comment on attachment 174768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174768&action=review lgtm > LayoutTests/ChangeLog:16 > + implement 4.1.3#Note2: Do we have a tracking bug on this?
(In reply to comment #5) > (From update of attachment 174768 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174768&action=review > > lgtm > > > LayoutTests/ChangeLog:16 > > + implement 4.1.3#Note2: > > Do we have a tracking bug on this? We didn't. Filed https://bugs.webkit.org/show_bug.cgi?id=102568
Tony, could you review this?
Comment on attachment 174768 [details] Patch rs=me
Comment on attachment 174768 [details] Patch Rejecting attachment 174768 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14880011
Created attachment 174786 [details] Patch for landing
Comment on attachment 174786 [details] Patch for landing Clearing flags on attachment: 174786 Committed r135028: <http://trac.webkit.org/changeset/135028>
All reviewed patches have been landed. Closing bug.