Bug 102551 - [CMake] Add support for winflexbison distribution
Summary: [CMake] Add support for winflexbison distribution
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 97592
  Show dependency treegraph
 
Reported: 2012-11-16 12:34 PST by Patrick R. Gansterer
Modified: 2012-11-26 11:13 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2012-11-16 12:39 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-11-16 12:34:16 PST
[CMake] Add support for winflexbison distribution
Comment 1 Patrick R. Gansterer 2012-11-16 12:39:29 PST
Created attachment 174746 [details]
Patch
Comment 2 Laszlo Gombos 2012-11-18 16:22:31 PST
Comment on attachment 174746 [details]
Patch

r=me. It looks to me that all cmake based ports can have this change. It would be great to get a confirmation from the Blackberry port before committing the patch.
Comment 3 Laszlo Gombos 2012-11-23 08:02:35 PST
Rob or any of the BB folks - is this change ok for the BlackBerry port ? I just want to check if this would cause any regression before landing it.
Comment 4 Ming Xie 2012-11-23 08:38:48 PST
Just ran a test build with your patch, and the BlackBerry port builds fine.

Please go ahead and submit your patch :)
Comment 5 Laszlo Gombos 2012-11-23 08:49:36 PST
Comment on attachment 174746 [details]
Patch

Thanks Ming.
Comment 6 WebKit Review Bot 2012-11-23 08:55:18 PST
Comment on attachment 174746 [details]
Patch

Clearing flags on attachment: 174746

Committed r135621: <http://trac.webkit.org/changeset/135621>
Comment 7 WebKit Review Bot 2012-11-23 08:55:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Laszlo Gombos 2012-11-23 18:05:24 PST
Patrick, please let us know if you had a chance to update the buildbot now that this patch is landed. Thanks !
Comment 9 Patrick R. Gansterer 2012-11-26 11:13:59 PST
(In reply to comment #8)
> Patrick, please let us know if you had a chance to update the buildbot now that this patch is landed. Thanks !

I already updated the binaries, but found an additional problem now. CMake does not recognice the version of win_flex, since it has a different output style.
I'm already in contact with the win_flex developer and working on a CMake patch. If the patch is so importet for you I can make some changes in the installed CMake version to work around this problem for now. :-/