Bug 102545 – Enable media stream on Android for Chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

This is part of effort to support WebRTC in Chrome on Android.

Created attachment 174886 [details]
Patch

[Peter Beverloo]

This will expose the feature, but will it actually work already? If I remember correctly, the run-time flag for media stream support defaults to being enabled, so unless it does work it'll break feature detection.

I'd also like to know what kind of impact this has on the binary size. Together with WebRTC (and any needed non-ffmpeg components), it could add a significant amount of data.

The leading WebRTC issue on Chromium for Android can be found at http://crbug.com/156384.
I'll reply to the one you filed (http://crbug.com/161417) so we can have this discussion on the Chromium tracker instead.

It takes many steps to make WebRTC work on Android. This is the first one which enables all necessary components to build. MEDIA_STREAM in WebKit is just one of the needed components. After that, we need to make sure all components work and add the missing components such as video capture device.

Regarding code size, that's a known issue. I'd have PM to discuss size issue.

[Adam Barth]

Comment on attachment 174886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174886&action=review

> Source/WebKit/chromium/features.gypi:166
> +          'ENABLE_MEDIA_STREAM=1',

You should move this outside the conditional block since it isn't conditional anymore.

[Adam Barth]

I'd like Peter to give and LGTM before we land this patch to make sure that he's happy with the change.

[Adam Barth]

s/and/an/

Created attachment 175001 [details]
Patch

[Peter Beverloo]

Comment on attachment 175001 [details]
Patch

I'm removing r? for now. We're holding off with enabling Media Stream until after the Chrome 25 branch point.

Thank you for uploading this patch, Wei Jia! We'll be able to land this later on.

Created attachment 179491 [details]
Patch

Peter,

The 3rd patch (id=179491) tries to set ENABLE_MEDIA_STREAM based on enable_webrtc. This puts all webrtc related stuff under one single flag. 

On Android, enable_webrtc is set to 0. So ENABLE_MEDIA_STREAM is set to 0, too. This will not change chromium on Android.

[Peter Beverloo]

Comment on attachment 179491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=179491&action=review

This seems good to me, with one minor nit. Thank you!

> Source/WebKit/chromium/ChangeLog:8
> +        Put all webrtc related stuff under one flag "enable_webrtc".

nit: Could you clarify in the ChangeLog that the "enable_webrtc" flag is enabled for Linux, Mac and Windows builds, but disabled for Android?

Created attachment 179764 [details]
Patch

Source/WebKit/chromium/ChangeLog has been updated according to the comment.

[Peter Beverloo]

+Eric for review.

[Eric Seidel (no email)]

I lean on tc for all my gyp reviews. :)  But this LGTM too.

[WebKit Review Bot]

Comment on attachment 179764 [details]
Patch

Clearing flags on attachment: 179764

Committed r138049: <http://trac.webkit.org/changeset/138049>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.